Skip to content

Add missing INLINE pragmas#538

Merged
Shimuuar merged 4 commits into
haskell:masterfrom
Shimuuar:missing-inline
Sep 5, 2025
Merged

Add missing INLINE pragmas#538
Shimuuar merged 4 commits into
haskell:masterfrom
Shimuuar:missing-inline

Conversation

@Shimuuar

@Shimuuar Shimuuar commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Fixes #532

They're always called with `m ~ ST s` so we should simply write more specialized
type in order to make GHC's life easier
@Shimuuar

Shimuuar commented Sep 3, 2025

Copy link
Copy Markdown
Contributor Author

As it turns out there's some room for improvement:

  • Missing INLINE on cmpBy
  • Helpers in Data.Vector.Mutable could be specialized to ST
  • Eq1 and Ord1 could be defined in terms of eqBy & cmpBy

@Shimuuar Shimuuar merged commit ec4da75 into haskell:master Sep 5, 2025
28 checks passed
@Shimuuar Shimuuar deleted the missing-inline branch September 5, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing INLINE pragmas

1 participant