Document GHC 91999 and GHC 86639#507
Open
dylan-thinnes wants to merge 2 commits intohaskellfoundation:mainfrom
Open
Document GHC 91999 and GHC 86639#507dylan-thinnes wants to merge 2 commits intohaskellfoundation:mainfrom
dylan-thinnes wants to merge 2 commits intohaskellfoundation:mainfrom
Conversation
Bodigrim
reviewed
Feb 2, 2025
Comment on lines
+19
to
+20
| There is more info on deriving instances for extra typeclasses in the [GHC user | ||
| manual](https://ghc.gitlab.haskell.org/ghc/doc/users_guide/exts/deriving_extra.html). |
Collaborator
There was a problem hiding this comment.
GitLab links can change, better to link documentation of a stable GHC release:
Suggested change
| There is more info on deriving instances for extra typeclasses in the [GHC user | |
| manual](https://ghc.gitlab.haskell.org/ghc/doc/users_guide/exts/deriving_extra.html). | |
| There is more info on deriving instances for extra typeclasses in the [GHC user manual](https://downloads.haskell.org/ghc/9.12.1/docs/users_guide/exts/deriving_extra.html). |
Bodigrim
reviewed
Feb 2, 2025
| `DerivingFunctor` language extension must be turned on. This can be done with a | ||
| pragma at the top of the file, or in build settings. | ||
|
|
||
| The `DerivingFunctor` extension is turned on automatically from Haskell2021 |
Collaborator
There was a problem hiding this comment.
Suggested change
| The `DerivingFunctor` extension is turned on automatically from Haskell2021 | |
| The `DerivingFunctor` extension is turned on automatically from GHC2021 |
Bodigrim
reviewed
Feb 2, 2025
|
|
||
| When deriving a `Functor` instance for a datatype in Haskell2010, the | ||
| `DerivingFunctor` language extension must be turned on. This can be done with a | ||
| pragma at the top of the file, or in build settings. |
Collaborator
There was a problem hiding this comment.
It might be worth mentioning that DeriveTraversable implies DeriveFunctor and also fixes the error.
Bodigrim
reviewed
Feb 2, 2025
| Any datatype that is exported from an .hs-boot file must be exported from the | ||
| corresponding .hs file. | ||
|
|
||
| More information on .hs-boot modules is available in [the GHC user manual](https://downloads.haskell.org/ghc/latest/docs/users_guide/separate_compilation.html#how-to-compile-mutually-recursive-modules). |
Collaborator
There was a problem hiding this comment.
The anchor is gone, I guess it's now
Suggested change
| More information on .hs-boot modules is available in [the GHC user manual](https://downloads.haskell.org/ghc/latest/docs/users_guide/separate_compilation.html#how-to-compile-mutually-recursive-modules). | |
| More information on .hs-boot modules is available in [the GHC user manual](https://downloads.haskell.org/ghc/9.12.1/docs/users_guide/separate_compilation.html#mutually-recursive-modules-and-hs-boot-files). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got two tickets at the workshop, wrote some quick docs - if there's anything that needs changing, please feel free to request.