fix(cli): set limit on workflow list to avoid truncated results - #4520
Open
var-raphael wants to merge 2 commits into
Open
fix(cli): set limit on workflow list to avoid truncated results#4520var-raphael wants to merge 2 commits into
var-raphael wants to merge 2 commits into
Conversation
|
@var-raphael is attempting to deploy a commit to the Hatchet Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
hatchet trigger manualcommand fetches the list of workflows to display viaWorkflowListWithResponse, but calls it with emptyWorkflowListParams{}. This means noLimitis set, so the API falls back to its default page size — meaning tenants with more workflows than that default only ever see the first page, and can't select or trigger any workflow beyond it.This fix sets an explicit
Limit: 100on both the interactive and non-interactive code paths, following the same pattern already used elsewhere in the CLI (e.g.crons.go,rate_limits.go,scheduled.go).Fixes #4429
Type of change
What's Changed
Limit: 100toWorkflowListParamsin bothrunManualInteractiveandrunManualNonInteractiveincmd/hatchet-cli/cli/trigger.go, sohatchet trigger manualcan list and trigger workflows beyond the API's default page size.Checklist
Changes have been:
go build ./cmd/hatchet-cli/...succeeds andgolangci-lintreports no new issues in the affected package)🤖 AI Disclosure
I acknowledge that an LLM was used in the creation of this Pull Request, in accordance with Hatchet's AI_POLICY.md.
Details: Claude was used to help investigate and diagnose the root cause of the bug (tracing from the issue report to the empty
WorkflowListParams{}call), confirm the fix pattern by cross-referencing similar code elsewhere in the repo, and draft this PR description. All code changes were reviewed and applied by me.