Open
Conversation
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
This is so the runCommand will be allowed to work. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
To see what services are running, and ram/free disk. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
This handles asking for admin rights as required. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
So that we can query their information, like the driver for the profile. This lets us use driver specific code if needed. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
There was a bug where the initial name is set, but you can't change it. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
So that it's easier to detect problems, and see load states. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Only show the start button once drivers have been detected. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
So on hyperv and vfkit things are configured as we want. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
For copying changes to the testplugin repo. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
This is used by the minikube driver called vfkit on mac. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Hides the script button used for debugging. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
This is to reduce the amount given for lower ram machines. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
It can be after computer restart that HyperV service is not enabled. Without this minikube start does not work. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
It can be HyperV is disabled after computer restart, so a running check is not sufficient. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
This is so it can make sure the VM service is running and also ask for privs to do it. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Because how we act depends on the driver and OS. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Sometimes it was not writing all data to stdout before exiting. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
If closing on cancel we do not need to reload the page. So clicking stop on a cluster and then cancel does not reload the page. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
On some systems wmic is not installed. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: gambtho <Thomas.Gamble@microsoft.com>
- Add isValidClusterName() to validate minikube profile names: must be non-empty, at most 63 characters, and start with an alphanumeric followed by alphanumerics or hyphens. Invalid names are now rejected with a descriptive error instead of being passed to the CLI. - Replace the boolean nameTaken state with a nameError string to support both uniqueness and format validation messages. - Memoize clusterNames via React.useMemo to prevent the generateClusterName useEffect from firing on every render. - Move generateClusterName to module scope and export for testability. Signed-off-by: gambtho <Thomas.Gamble@microsoft.com>
…mand execution - Track non-zero exit codes and surface a commandError flag so the UI can distinguish success from failure. - Display an error banner in CommandDialog when a command fails. - Kill the spawned minikube process when the dialog is closed or the action is cancelled while a command is still running. - Cap displayed output lines to 200 to prevent unbounded memory growth and rendering slowdown from verbose commands. Signed-off-by: gambtho <Thomas.Gamble@microsoft.com>
…Minikube - Consolidate 6 duplicated registerClusterProviderMenuItem and registerClusterProviderDialog calls into a data-driven loop over a minikubeCommands array, reducing ~110 lines to ~40. - Rename the onConfirm prop to onCommandDispatched on CommandCluster to accurately reflect that it fires at dispatch time, not on completion. - Add a type annotation and export to isMinikube for type safety and testability. Signed-off-by: gambtho <Thomas.Gamble@microsoft.com>
…tability - Add 21 unit tests covering isElectron, isMinikube, detectOS, isValidClusterName, and generateClusterName. - Export detectOS from DriverSelect for test imports. - Add CommandFailed and GridCommandFailed storybook stories exercising the new commandError prop. - Remove @ts-nocheck from storybook.test.tsx as the import resolves cleanly without it. Signed-off-by: gambtho <Thomas.Gamble@microsoft.com>
Signed-off-by: gambtho <Thomas.Gamble@microsoft.com>
gambtho
force-pushed
the
minikube-fixes2-rebased
branch
2 times, most recently
from
9c8e068 to
855f0b0
Compare
Signed-off-by: gambtho <Thomas.Gamble@microsoft.com>
gambtho
force-pushed
the
minikube-fixes2-rebased
branch
from
855f0b0 to
1cdca3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.