Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5312.
Summary
Rails routes HEAD requests through GET routes, so a HEAD request to the confirmation URL currently reaches
ConfirmationsController#showand callsconfirm_by_token, confirming the account.This change returns
200 OKbefore processing the token when the original request method is HEAD. Returning a successful response lets email link scanners validate that the URL is reachable without changing account state. It also avoids a405 Method Not Allowedresponse, which may cause a scanner to retry the URL with GET and trigger the same confirmation.The existing GET confirmation flow is intentionally unchanged. Moving confirmation to a separate POST action would be a larger compatibility change and is outside the scope of this fix.
Tests
ruby -Itest test/integration/confirmable_test.rb(34 runs, 82 assertions)rake test(879 runs, 2472 assertions)