Repository navigation
Document how to defer schema lookups in Devise models - #5884
Draft
merouaneamqor wants to merge 1 commit into
Draft
merouaneamqor wants to merge 1 commit into
merouaneamqor wants to merge 1 commit into
Conversation
merouaneamqor
marked this pull request as draft
November 10, 2026 21:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devise_forloads the mapped model while drawing routes. On Rails 7.2,bin/rails db:createcan draw routes before creating the database, so a schema lookup in the model's class body raisesActiveRecord::NoDatabaseError.Document how to defer a schema-backed validation limit until validation runs. This preserves the column limit and leaves Devise's routing behavior unchanged.
Verified with Rails 7.2.4 and MySQL 8.0. The reproduction failed before the model change and passed afterward. It covered database creation, the sign-in route, the email length boundary, and propagation of the missing database error when the model is used. The Devise Active Record suite passed with 878 tests and 2,456 assertions.
Related to #5786.