Repository navigation
Show the real default in the generated parent_controller comment - #5885
Open
farisbasha wants to merge 1 commit into
Open
farisbasha wants to merge 1 commit into
farisbasha wants to merge 1 commit into
Conversation
The commented-out example in the generated initializer suggested `config.parent_controller = 'DeviseController'`. DeviseController itself inherits from `Devise.parent_controller.constantize`, so uncommenting that line makes it try to inherit from itself. The default in lib/devise.rb is "ApplicationController", so show that instead, like the other commented settings in the template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated initializer (
lib/generators/templates/devise.rb) has this commented-out example:DeviseControlleris the class that uses this setting:so uncommenting the example as written would make
DeviseControllertry to inherit from itself. The real default inlib/devise.rbis@@parent_controller = "ApplicationController".This changes the comment to show
'ApplicationController', like the other commented settings in the template, which show their defaults. Comment-only change in the generator template; no behavior change.An AI assistant helped find this and prepare the change.