Avoid completion conflict with modern 'nix' CLI #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream nix (>=2.4) has completion for the modern 'nix' CLI, and the completion provided by nix-bash-completions cause a conflict that breaks completion: $ nix build<TAB_TAB> # line gets erased Fix it by not installing completion for 'nix', which lets Nix handle its own completions. As a side effect, this breaks/removes completion for the experimental 'nix' commands in nix<=2.3, but hopefully there is no real use case for that anymore as even the latest NixOS version use nix>=2.8. Fixes hedning#20.
|
Ping? |
|
Ping. NixOS 22.05 has Nix 2.8.1, which means completing modern |
|
@hedning: friendly ping |
|
@ncfavier: friendly ping? |
|
I want this as much as you do, but the maintainer is unresponsive. Perhaps it is time to add this patch in nixpkgs. |
Oh, I guess I assumed you had commit rights based on this comment, and I realized I hadn't pinged you in this PR. Ok, nixpkgs next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[This supersedes https://github.com//pull/21.]
Upstream nix (>=2.4) has completion for the modern 'nix' CLI, and the
completion provided by nix-bash-completions cause a conflict that breaks
completion:
$ nix build<TAB_TAB> # line gets erased
Fix it by not installing completion for 'nix', which lets Nix handle its
own completions.
As a side effect, this breaks/removes completion for the experimental
'nix' commands in nix<=2.3, but hopefully there is no real use case for
that anymore as even the latest NixOS version use nix>=2.8.
Fixes #20.