uniffi: Update to latest version of uniffi (0.31) - #143
Merged
Conversation
ChillerDragon
force-pushed
the
pr_uniffi31
branch
from
June 12, 2026 08:49
97ba5f3 to
107a7da
Compare
heinrich5991
left a comment
heinrich5991
left a comment
Owner
There was a problem hiding this comment.
Thanks for fixing the uniffi stuff. :)
It seems you've run cargo update. Please revert Cargo.lock changes and re-generate Cargo.lock by runnning something like cargo check.
Please use present tense in the commit message.
If you don't want to adjust your PR, you can also close it, I already reproduced the changes locally.
Contributor
Author
|
Yes I intentionally deleted Cargo.lock to update all the dependencies. cargo check does not do that for me. |
ChillerDragon
force-pushed
the
pr_uniffi31
branch
from
June 12, 2026 12:06
107a7da to
cd7627d
Compare
Closes heinrich5991#142 Closes heinrich5991#130 I could reproduce the issue heinrich5991#142 locally by running `python -m build` in the `./uniffi/huffman` directory. And updating uniffi did resolve the issue.
This reverts commit 536afc8.
ChillerDragon
force-pushed
the
pr_uniffi31
branch
from
June 12, 2026 12:08
cd7627d to
75131e2
Compare
Contributor
Author
|
Ah okay if I change the Cargo.toml uniffi version and then |
Contributor
Author
|
@heinrich5991 could you do a new pypi release so my pip install works again? :) |
Owner
|
Done, libtw2-huffman 0.2.2 released on PyPI. |
ChillerDragon
added a commit
to ChillerDragon/teeworlds-web-traffic-decoder
that referenced
this pull request
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #142
Closes #130
I could reproduce the issue #142 locally by running
python -m buildin the./uniffi/huffmandirectory. And updating uniffi did resolve the issue.