Document ClientOptLogger for SDK registry client#2116
Open
promptless-for-oss wants to merge 2 commits into
Open
Document ClientOptLogger for SDK registry client#2116promptless-for-oss wants to merge 2 commits into
promptless-for-oss wants to merge 2 commits into
Conversation
Document the new registry.ClientOptLogger option that allows SDK users to inject a custom *slog.Logger when creating a registry client. This prevents Helm from mutating global process state, which is important when embedding Helm as a library. Closes helm/helm#31724 Signed-off-by: promptless[bot] <promptless[bot]@users.noreply.github.com>
| @@ -55,6 +56,13 @@ func newRegistryClient(settings *cli.EnvSettings, certFile, keyFile, caFile stri | |||
| opts = append(opts, registry.ClientOptPlainHTTP()) | |||
| } | |||
Contributor
Author
There was a problem hiding this comment.
Added registry.ClientOptLogger documentation based on PR #31833, which introduces this new option to allow SDK users to inject custom *slog.Logger instances rather than relying on global slog state.
Source: helm/helm#31833
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open this suggestion in Promptless to view citations and reasoning process
Adds documentation for the new registry.ClientOptLogger option that allows SDK users to inject a custom *slog.Logger when creating a registry client, preventing Helm from mutating global process state.
Trigger Events
Tip: Use labels in the Promptless dashboard to categorize suggestions by release or team 🏷️