Jules PR #10
Jules PR #10
Conversation
… to the `mmv1/third_party/tgc/resource_converters.go.tmpl` file and verified the change. I have created the `kms_crypto_key_version.tf` and `kms_crypto_key_version.json` test files in the `mmv1/third_party/tgc/tests/data` directory and verified their creation. I have updated the `kms_crypto_key_version.json` file to use `ancestry_path` as per your instruction.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
… to the `mmv1/third_party/tgc/resource_converters.go.tmpl` file and verified the change. I have created the `kms_crypto_key_version.tf` and `kms_crypto_key_version.json` test files in the `mmv1/third_party/tgc/tests/data` directory and verified their creation. I have updated the `kms_crypto_key_version.json` file to use `ancestry_path` as per your instruction. I have removed the existing `terraform-google-conversion` directory, re-cloned it, and regenerated the converter code using `make tgc`. I have re-applied the fixes for the `workbench` and `accesscontextmanager` build errors. I have updated the `kms_crypto_key_version.json` file to match the actual output from the failed test.
Co-authored-by: Zhenhua Li <[email protected]>
Removing rotation period as it is not easy to test it generates nextRotation date in future from current time.
Removed rotationPeriod from data in kms_crypto_key_version.json.
Co-authored-by: Zhenhua Li <[email protected]>
Jules PR
PR created automatically by Jules for task 3626048682571471046