-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Add vmwareengine cluster converter #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
| "version": "v1", | ||
| "discovery_document_uri": "https://vmwareengine.googleapis.com/$discovery/rest", | ||
| "discovery_name": "Cluster", | ||
| "parent": "//cloudresourcemanager.googleapis.com/projects/{{.Project.Number}}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "parent": "//cloudresourcemanager.googleapis.com/projects/{{.Project.Number}}", | |
| "parent": "//cloudresourcemanager.googleapis.com/projects/{{.Provider.project}}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
| "discovery_name": "Cluster", | ||
| "parent": "//cloudresourcemanager.googleapis.com/projects/{{.Project.Number}}", | ||
| "data": { | ||
| "name": "projects/{{.Provider.project}}/locations/us-central1-a/privateClouds/gg-asset-pc-38930-c6db/clusters/gg-asset-cl-38930-c6db", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "name": "projects/{{.Provider.project}}/locations/us-central1-a/privateClouds/gg-asset-pc-38930-c6db/clusters/gg-asset-cl-38930-c6db", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
| "discovery_name": "Cluster", | ||
| "parent": "//cloudresourcemanager.googleapis.com/projects/{{.Provider.project}}", | ||
| "data": { | ||
| "name": "projects/{{.Provider.project}}/locations/us-central1-a/privateClouds/gg-asset-pc-38930-c6db/clusters/gg-asset-cl-38930-c6db", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "name": "projects/{{.Provider.project}}/locations/us-central1-a/privateClouds/gg-asset-pc-38930-c6db/clusters/gg-asset-cl-38930-c6db", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
88d1163 to
172c3f4
Compare
Adds a converter for the `google_vmwareengine_cluster` resource, and a corresponding test case.
172c3f4 to
e455331
Compare
This change introduces a new converter for the
google_vmwareengine_clusterresource, enabling the conversion of Terraform plans to CAI format. A test case is also included to validate the converter's functionality.PR created automatically by Jules for task 3506915735971980056