feat: Add converter for vmwareengine.googleapis.com/PrivateCloud #17
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
| "discovery_name": "PrivateCloud", | ||
| "parent": "//cloudresourcemanager.googleapis.com/projects/{{.Provider.project}}", | ||
| "data": { | ||
| "name": "projects/{{.Provider.project}}/locations/us-central1-a/privateClouds/gg-asset-pc-00563-8560", |
There was a problem hiding this comment.
| "name": "projects/{{.Provider.project}}/locations/us-central1-a/privateClouds/gg-asset-pc-00563-8560", |
| }, | ||
| "networkConfig": { | ||
| "managementCidr": "192.168.0.0/24", | ||
| "vmwareEngineNetwork": "projects/{{.Provider.project}}/locations/global/vmwareEngineNetworks/gg-asset-vmw-net-00563-8560" |
There was a problem hiding this comment.
| "vmwareEngineNetwork": "projects/{{.Provider.project}}/locations/global/vmwareEngineNetworks/gg-asset-vmw-net-00563-8560" |
| "vmwareEngineNetwork": "projects/{{.Provider.project}}/locations/global/vmwareEngineNetworks/gg-asset-vmw-net-00563-8560" | ||
| } | ||
| }, | ||
| "location": "us-central1-a" |
There was a problem hiding this comment.
| "location": "us-central1-a" |
| resource "google_vmwareengine_network" "main" { | ||
| name = "gg-asset-vmw-net-00563-8560" | ||
| location = "global" | ||
| type = "STANDARD" | ||
| description = "Standard VMware Engine Network" | ||
| project = "{{.Provider.project}}" | ||
| } |
|
|
||
| network_config { | ||
| management_cidr = "192.168.0.0/24" | ||
| vmware_engine_network = google_vmwareengine_network.main.id |
There was a problem hiding this comment.
| vmware_engine_network = google_vmwareengine_network.main.id | |
| vmware_engine_network = "projects/{{.Provider.project}}/locations/global/vmwareEngineNetworks/test_vmware_network" |
| } | ||
| }, | ||
| "networkConfig": { | ||
| "managementCidr": "192.168.0.0/24" |
There was a problem hiding this comment.
| "managementCidr": "192.168.0.0/24" | |
| "managementCidr": "192.168.0.0/24", | |
| "vmwareEngineNetwork": "projects/{{.Provider.project}}/locations/global/vmwareEngineNetworks/test_vmware_network" |
hemantadil
force-pushed
the
feat-vmwareengine-private-cloud-converter
branch
from
19dc96b to
c9cf14e
Compare
This commit adds a converter for the vmwareengine.googleapis.com/PrivateCloud asset type. It includes: - Registration of the `google_vmwareengine_private_cloud` converter. - A test case with `.tf` and `.json` files. Note: The tests are currently failing and require further investigation. I was unable to create a stable testing environment to fully validate the changes.
hemantadil
force-pushed
the
feat-vmwareengine-private-cloud-converter
branch
from
c9cf14e to
d08b98b
Compare
This pull request adds a converter for the
vmwareengine.googleapis.com/PrivateCloudasset type. It includes the converter registration and a test case. The tests are currently failing and require further investigation.PR created automatically by Jules for task 2739084004400994930