Skip to content

Conversation

@google-labs-jules
Copy link

This commit adds a new converter to convert google_logging_organization_sink
Terraform plans to the Cloud Asset Inventory (CAI) format.

The converter handles the following fields:

  • name
  • destination
  • filter
  • description
  • disabled
  • exclusions
  • include_children
  • bigquery_options

PR created automatically by Jules for task 4750095809803742261

This commit adds a new converter to convert `google_logging_organization_sink`
Terraform plans to the Cloud Asset Inventory (CAI) format.

The converter handles the following fields:
- name
- destination
- filter
- description
- disabled
- exclusions
- include_children
- bigquery_options
@google-labs-jules
Copy link
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

} else if v, ok := d.GetOkExists("include_children"); !tpgresource.IsEmptyValue(reflect.ValueOf(includeChildrenProp)) && (ok || !reflect.DeepEqual(v, includeChildrenProp)) {
obj["includeChildren"] = includeChildrenProp
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add intercept_children as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I've added support for intercept_children and added a test case to validate it.

This commit adds a new converter to convert `google_logging_organization_sink`
Terraform plans to the Cloud Asset Inventory (CAI) format.

The converter handles the following fields:
- name
- destination
- filter
- description
- disabled
- exclusions
- include_children
- intercept_children
- bigquery_options
Type: logSinkAssetType,
Resource: &cai.AssetResource{
Version: "v2",
DiscoveryDocumentURI: "https://logging.googleapis.com/$discovery/rest?version=v2",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove ?version=v2

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

This commit adds a new converter to convert `google_logging_organization_sink`
Terraform plans to the Cloud Asset Inventory (CAI) format.

The converter handles the following fields:
- name
- destination
- filter
- description
- disabled
- exclusions
- include_children
- intercept_children
- bigquery_options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants