-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Add converter for logging_organization_sink #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This commit adds a new converter to convert `google_logging_organization_sink` Terraform plans to the Cloud Asset Inventory (CAI) format. The converter handles the following fields: - name - destination - filter - description - disabled - exclusions - include_children - bigquery_options
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
| } else if v, ok := d.GetOkExists("include_children"); !tpgresource.IsEmptyValue(reflect.ValueOf(includeChildrenProp)) && (ok || !reflect.DeepEqual(v, includeChildrenProp)) { | ||
| obj["includeChildren"] = includeChildrenProp | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add intercept_children as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I've added support for intercept_children and added a test case to validate it.
This commit adds a new converter to convert `google_logging_organization_sink` Terraform plans to the Cloud Asset Inventory (CAI) format. The converter handles the following fields: - name - destination - filter - description - disabled - exclusions - include_children - intercept_children - bigquery_options
| Type: logSinkAssetType, | ||
| Resource: &cai.AssetResource{ | ||
| Version: "v2", | ||
| DiscoveryDocumentURI: "https://logging.googleapis.com/$discovery/rest?version=v2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove ?version=v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
This commit adds a new converter to convert `google_logging_organization_sink` Terraform plans to the Cloud Asset Inventory (CAI) format. The converter handles the following fields: - name - destination - filter - description - disabled - exclusions - include_children - intercept_children - bigquery_options
This commit adds a new converter to convert
google_logging_organization_sinkTerraform plans to the Cloud Asset Inventory (CAI) format.
The converter handles the following fields:
PR created automatically by Jules for task 4750095809803742261