Repository navigation
fix: stop queuing stale screens for tui clients that stop reading - #6097
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Severity of issue fixed: Medium Merge Risk:
|
|
@coderabbitai review |
Action performed
|
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryThis PR bounds each client's queued screen state while keeping notifications and replies in order.
No actionable issues found. Tests were not run during this review. ogulcancelik reports that Windows CI is blocked by the runner image until #6093 lands; the new named-pipe test awaits that run.
|
refs #5471
when a connected tui client stops reading (a laptop asleep while attached over ssh), the server kept every screen update for it and its memory grew without bound (16 GB after a few days in the report). now only the latest pending screen state is kept for a client, so a stalled client costs a fixed amount and resumes normally when it wakes. notifications and other replies are still delivered in order. a 64 MiB per-client cap on that queue disconnects a client as a last resort.
reproduced on 0.9.5 and master on a linux box: a frozen client's server grew +0.57 MiB/min vs a normal one leveling off; with the fix both level off over 25 min, the frozen client resumes on the same connection with the right screen, and a slow client reading 75 MB of images isn't disconnected. no wire change. windows ci is red until #6093 lands (runner image); the new windows named-pipe test needs that run.