Skip to content

[Feature] : Delete Funtionality added #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dhirajudhani
Copy link

@dhirajudhani dhirajudhani commented May 12, 2024

Description

I have created a button which has functionality to delete notes . For more understanding please see recording of it

Resolves: [#48]

Checklist

Before submitting this pull request, kindly verify that the ensuing checkpoints have been reached.

  • Have you adhered to the repository's defined coding convention rules?
  • Have you updated the 'documentation.md' file with the method/function documentation?
  • Have you sent a message along with the result or response?
  • Have you used the try-catch technique?
  • Has the method/class been added to the documentation (md file)?

Screenshots

Screencast.from.12-05-24.10.07.57.AM.IST.webm

Additional Notes/Comments

@hereisSwapnil please review it and if there are changes please let me know


I certify that I have carried out the relevant checks and provided the requisite screenshot for validation by submitting this pull request.
I appreciate your contribution.

Copy link

vercel bot commented May 12, 2024

Someone is attempting to deploy a commit to the swapnilsingh99's projects Team on Vercel.

A member of the Team first needs to authorize it.

@hereisSwapnil
Copy link
Owner

@dhirajudhani Please resolve conflicts

@dhirajudhani
Copy link
Author

@hereisSwapnil I have solved all conflicts can please review now

@dhirajudhani
Copy link
Author

Hii @hereisSwapnil i have again resolved the conflicts now please review it firstly , as you merge other repo due that merge conflicts are coming its request if possible can review it

@hereisSwapnil
Copy link
Owner

image

This is not looking good and also delete button should be present only if I have uploaded those notes

@dhirajudhani
Copy link
Author

hii @hereisSwapnil first off all for responsive case at my side in a mobile view its looking perfect have a look
Screenshot from 2024-05-14 07-41-14
Secondly as your concern we can only delete the notes after uploading only you can check my video which i have shared in above first i am creating the notes only then I can delete ir.

@hereisSwapnil
Copy link
Owner

@dhirajudhani Please fix the delete button should only be visible if the notes have been uploaded by me
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants