-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable writing a log file via a --no-log-file flag #1877
base: main
Are you sure you want to change the base?
Conversation
|
🦋 Changeset detectedLatest commit: 6971f5b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this option under logs
as logs.file
(?)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1877 +/- ##
==========================================
- Coverage 57.23% 57.23% -0.01%
==========================================
Files 191 191
Lines 25954 25956 +2
Branches 1964 1964
==========================================
+ Hits 14856 14857 +1
- Misses 11089 11090 +1
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Yeah, good idea. I'mma work it there |
Pushed a new revision with the option being under |
@@ -135,6 +135,23 @@ export interface UserConfig { | |||
| (string & {}) | |||
| Record<string, unknown> | |||
| Input; | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's up with this diff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea. I merely ran the linters / formatters at the pre commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting this accidental diff is the last thing!
Thanks for the comments, Implemented now. |
@@ -135,6 +135,23 @@ export interface UserConfig { | |||
| (string & {}) | |||
| Record<string, unknown> | |||
| Input; | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting this accidental diff is the last thing!
Of course. The one thing I didn't realize to run. Fixing.. |
@hey-api/client-axios
@hey-api/client-fetch
@hey-api/client-next
@hey-api/client-nuxt
@hey-api/nuxt
@hey-api/openapi-ts
@hey-api/vite-plugin
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woo
Heya,
While writing a Vite plugin for Hey Api I ran into the situation where it kept pushing out a lot of log files on failed attempts.
There is the log level silent solution, but that also supresses logs from successful runs etc. so I think it would be great to be able to explicitly disable the error output log file while keeping the console logs
Please let me know if I missed something