-
-
Notifications
You must be signed in to change notification settings - Fork 166
fix: make oneOf discriminator props required #2006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@hey-api/client-axios
@hey-api/client-fetch
@hey-api/client-nuxt
@hey-api/client-next
@hey-api/nuxt
@hey-api/openapi-ts
@hey-api/vite-plugin
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2006 +/- ##
==========================================
- Coverage 22.28% 22.27% -0.01%
==========================================
Files 252 252
Lines 21385 21387 +2
Branches 795 795
==========================================
Hits 4765 4765
- Misses 16614 16616 +2
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why only 3.0.x snapshots are affected? You touched the 3.1.x parser too, so I'd expect those to be updated too. Perhaps different parts of the code were altered?
EDIT: I see it's because you touched the allOf
function instead of oneOf
in 3.1.x. I'll fix it
@mrlubos ops, thanks for that! |
Closes #1561
Fix for the issue that discriminator.propertyName becomes optional in generated type.
https://github.com/OAI/OpenAPI-Specification/blob/3.0.3/versions/3.0.3.md#discriminator-object
Seems this should be always the case according to the spec too (same for 3.1.0).