-
-
Notifications
You must be signed in to change notification settings - Fork 172
Add interceptor indexes #2029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add interceptor indexes #2029
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadly agree with the changes! I understand you prefer the Axios-like syntax. My only ask is to preserve the current behaviour so it doesn't break for people
@mrlubos I've made additional changes, but the failing test fails for me on Main as well as the branch. How would you prefer to proceed? |
Thanks! I'll have a look at the failing test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe to make your tests pass... build each touched client, i.e. pnpm client fetch build
, pnpm client custom build
, and seems you want to also do pnpm client next build
. After that, update actual tests with pnpm openapi-ts-tests test:update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you're updating the Next.js client documentation, but none of the client files were touched
Solves #2018