Skip to content

Add interceptor indexes #2029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

henry-encord
Copy link

Solves #2018

  • Adds indexes (ids) to interceptors so they can be accessed by id rather than reference.
  • Updates the docs for affected parts

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented May 9, 2025

⚠️ No Changeset found

Latest commit: f84bab2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 11:09am

Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly agree with the changes! I understand you prefer the Axios-like syntax. My only ask is to preserve the current behaviour so it doesn't break for people

@henry-encord
Copy link
Author

@mrlubos I've made additional changes, but the failing test fails for me on Main as well as the branch. How would you prefer to proceed?

@henry-encord henry-encord marked this pull request as ready for review May 12, 2025 11:19
@mrlubos
Copy link
Member

mrlubos commented May 12, 2025

Thanks! I'll have a look at the failing test

Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe to make your tests pass... build each touched client, i.e. pnpm client fetch build, pnpm client custom build, and seems you want to also do pnpm client next build. After that, update actual tests with pnpm openapi-ts-tests test:update

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you're updating the Next.js client documentation, but none of the client files were touched

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants