HHH-19464 storing a binary data into blob on oracle cutting off its content #10160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cigaly
changed the title
mbladel
reviewed
May 19, 2025
|
|
||
| @Test | ||
| void hibernate_blob_streaming(SessionFactoryScope scope) throws Exception { | ||
| final var zipFilePath = getClass().getClassLoader().getResource( "org/hibernate/orm/test/lob/JarFileEntryBlobTest.zip" ); |
There was a problem hiding this comment.
Not great (and potentially dangerous) to have a zip file just for testing purposes. Could we reproduce the error with a simple byte-array and org.hibernate.engine.jdbc.proxy.BlobProxy?
There was a problem hiding this comment.
Any stream that will always read complete buffer (with exception of last read) will not expose this problem. java.util.zip.InflaterInputStream can return less bytes before reading next bytes to be deflated.
Possible way to avoid zip file in resources is to create it temporary on th fly.
To avoid this GZIPOutputStream can be used to deflate (random) bytes, then GZIPInputStream can be used to create blob.
…]) returns less bytes than buffer length
cigaly
force-pushed
the
HHH-19464-Storing_a_binary_data_into_BLOB_on_Oracle_cutting_off_its_content
branch
from
a69a8b7 to
baad677
Compare
cigaly
force-pushed
the
HHH-19464-Storing_a_binary_data_into_BLOB_on_Oracle_cutting_off_its_content
branch
from
baad677 to
0add274
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue HHH-19464
In
org.hibernate.type.descriptor.java.DataHelper#extractBytes(java.io.InputStream, long, int)assumption thatjava.io.InputStream#read(byte[])reached EOF when number of bytes read is less than size of buffer is not correct.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.