HHH-19522 upsert should not fail silently instead of throwing StaleObjectStateException #10289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
upsert() should throw StaleObjectStateException if the version verification fails
- also fix the problem for upsert emulation with UPDATE/INSERT
- also fix the problem for Oracle
gavinking
commented
Jun 6, 2025
Comment on lines
195
to
217
| final var statementDetails = statementGroup.resolvePreparedStatementDetails( tableMapping.getTableName() ); | ||
| try { | ||
| final PreparedStatement updateStatement = statementDetails.resolveStatement(); | ||
| session.getJdbcServices().getSqlStatementLogger().logStatement( statementDetails.getSqlString() ); | ||
| final JdbcServices jdbcServices = session.getJdbcServices(); | ||
| jdbcServices.getSqlStatementLogger().logStatement( statementDetails.getSqlString() ); | ||
| jdbcValueBindings.beforeStatement( statementDetails ); | ||
| final int rowCount = | ||
| session.getJdbcCoordinator().getResultSetReturn() | ||
| .executeUpdate( updateStatement, statementDetails.getSqlString() ); | ||
| MODEL_MUTATION_LOGGER.tracef( "`%s` rows upserted into `%s`", rowCount, tableMapping.getTableName() ); | ||
| try { | ||
| expectation.verifyOutcome( rowCount, updateStatement, -1, statementDetails.getSqlString() ); | ||
| } | ||
| catch (SQLException e) { | ||
| throw jdbcServices.getSqlExceptionHelper().convert( | ||
| e, | ||
| "Unable to verify outcome for upsert", | ||
| statementDetails.getSqlString() | ||
| ); | ||
| } | ||
| } | ||
| finally { | ||
| statementDetails.releaseStatement( session ); |
There was a problem hiding this comment.
@sebersole Why does this stuff not go through a MutationCoordinator/MutationExecutor?
I'm not clear on how these differ from MutationOperation.
|
I have not got any feedback on this one (after asking for feedback on Zulip), so I'm going to assume that nobody has any better ideas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19522