HHH-20414 - Deprecated generator removals#13049
Open
jrenaat wants to merge 4 commits into
Open
Conversation
Removed the deprecated ForeignGenerator class which was marked for removal in version 9. The functionality is replaced by the JPA-standard @mapsid annotation. Changes: - Removed ForeignGenerator class - Removed "foreign" generator strategy from GeneratorStrategies - Updated JavaDoc to reference @mapsid instead of ForeignGenerator - Migrated test entities from @GenericGenerator to @mapsid The core getForeignId() helper method is preserved as it's still used by PropertyBinder to implement @mapsid functionality. Migration path for users: Old: @GenericGenerator(type = ForeignGenerator.class, parameters = @parameter(name="property", value="owner")) New: @mapsid Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
hibernate-github-bot
Bot
added
the
wip/9.0
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
Member
|
Looks reasonable to me so far |
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
sebersole
reviewed
Jul 17, 2026
sebersole
requested changes
Jul 17, 2026
sebersole
left a comment
sebersole
left a comment
Member
There was a problem hiding this comment.
Minor doc change, but otherwise looks good
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
jrenaat
force-pushed
the
HHH-20414-deprecated_generator_removals
branch
from
July 17, 2026 17:27
2c13192 to
ddbd513
Compare
jrenaat
marked this pull request as ready for review
July 17, 2026 17:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
Please make sure that the following tasks are completed:
Tasks specific to HHH-20414 (Remove Feature):
documentation/src/main/asciidoc/userguidefor all features,documentation/src/main/asciidoc/introductionfor main features, links from existing documentationmigration-guide.adoc(breaking changes) andwhats-new.adoc(new features/improvements)https://hibernate.atlassian.net/browse/HHH-20414