HHH-18829 Auto generate record ID class if no explicit @IdClass #9220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Last two commits are idea for potential solution on Hibernate Core side. |
gavinking
reviewed
Nov 8, 2024
| pw.println( ") {}" ); | ||
| pw.println(); | ||
| } | ||
| } |
There was a problem hiding this comment.
This is nice and simple, for sure, but it's kind-of a layer-breaker. It would be better to make a new subclass of AnnotationMeta for this, even though I admit that's a PITA.
[I don't love the architecture, but it's not terrible, and it's what we've inherited.
There was a problem hiding this comment.
You're right, but I think that generated ID class should be member of generated entity (or embeddable?) meta class. Then it should be implementing MetaAttribute which is less than half PITA :-)
Additional thing is that order of record components should be preserved. At least one test in core failed due to that.
…or when class is not annotated with @IdClass, but have more than one member annotated with @id
…ID class can not be resolved
…rties in entity class
…into preserve order of record components in generated ID class
…ber of parent AnnotationMetaEntity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue HHH-18829
This is "sketch" of the problem solution on the side of Hibernate Processor.
TODO : Change Hibernate Core to use generated ID class.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.