HHH-18818 Fix ID conflicts between CTE batch inserts and PooledOptimizer sequence allocation #9232
+130
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zer sequence allocation
stringintech
force-pushed
the
HHH-18818
branch
from
27b4751
to
7d7ac39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an ID conflict in Hibernate's
CteInsertHandlerbatch insert implementation when using sequence-based ID generation with thePooledOptimizer. The issue arises from a misalignment between the batch insert ID generation strategy and thePooledOptimizerstrategy, which can lead to ID conflicts.The fix ensures that
CteInsertHandlercorrectly integrates with thePooledOptimizer's ID allocation strategy by properly handling the next database-generated sequence value as the "hi" value, thereby maintaining consistent ID allocation across all insert operations.A unit test (
CteInsertStrategyWithPooledOptimizerTest) is included to validate the fix.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-18818