HHH-19229 Faster checks in ReflectHelper

[obourgain]

Make the checks in ReflectHelper faster.
See detailed description in Jira

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

---

[hibernate-github-bot]

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

[obourgain]

pipeline seems to be stuck

[sebersole]

The oracle job failure is an occasional, transient problem - probably not anything wrong with your PR.

The code analysis though you will need to resolve.

[mbladel]

Left a couple comments. I found it weird that tests were passing since the checks you implemented were not correct, and I found some duplicated logic in org.hibernate.property.access.internal.AccessStrategyHelper#checkIsMethodVariant.

Could you please delete this method and ensure we use ReflectHelper#verifyNoIsVariantExists instead?

[mbladel]

Code style and correct region-matching.

Suggested change

	&& declaredMethod.getName().startsWith("is")
	&& declaredMethod.getName().regionMatches(0, stemName, 0, stemName.length() )
	&& declaredMethod.getName().startsWith( "is" )
	&& declaredMethod.getName().regionMatches( 2, stemName, 0, stemName.length() )

[mbladel]

Suggested change

	&& declaredMethod.getName().startsWith("is")
	&& declaredMethod.getName().regionMatches(0, stemName, 0, stemName.length() )
	&& declaredMethod.getName().startsWith( "get" )
	&& declaredMethod.getName().regionMatches( 3, stemName, 0, stemName.length() )