HHH-19284 : Refactor - Extract duplicated vector distance function registration

[0xC0FFE2]

Extracted duplicated vector distance function registration code into a helper method to improve code clarity and maintenance.

https://hibernate.atlassian.net/browse/HHH-19284

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

---

[hibernate-github-bot]

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [f3cbdd4]

› This message was automatically generated.

[yrodiere]

Hello @0xC0FFE2 ,

Thanks for your contribution.

While I agree your code is a slight improvement, I want to stress that refactoring for the sake of it is not something the whole Hibernate team sees with a good eye, especially if it's just some very localized problem: the cost of doing that refactoring and reviewing it often outweighs the benefits.

I'm ready to merge this, but:

1. If you are looking for ways to contribute to Hibernate, please have a look at the good first issues.
2. Please rebase your branch on the main branch to remove the "merge commit" -- we don't allow those.

[gavinking]

I'm ready to merge this

I for one would not merge this, not unless a similar change is done in the VectorContributors for the other dialects. As it is, this introduces an inconsistency between the dialects.