Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSEARCH-5064 Integrate Elasticsearch's knn query introduced in 8.12 #3934

Conversation

marko-bekhta
Copy link
Member

https://hibernate.atlassian.net/browse/HSEARCH-5064

Another dialect doesn't look too terrible 😃 ... it seems ... 😃

@marko-bekhta marko-bekhta force-pushed the feat/HSEARCH-5064-Integrate-Elasticsearchs-knn-query-introduced-in-812 branch from 45e9758 to db210b8 Compare January 29, 2024 13:41
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, though I still think we should remove support for 8.11 (along with all the limitation warnings spread through the docs).

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marko-bekhta marko-bekhta force-pushed the feat/HSEARCH-5064-Integrate-Elasticsearchs-knn-query-introduced-in-812 branch from 4382b0e to e5aa91d Compare January 29, 2024 17:45
@marko-bekhta
Copy link
Member Author

sorry noticed that I've missed to rename one test method 🙈

Copy link

@marko-bekhta marko-bekhta merged commit 686421e into hibernate:main Jan 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants