CurveCWSFourier Class for CWS bounded coil optimization#420
Draft
joaopedrobiu6 wants to merge 131 commits intohiddenSymmetries:masterfrom
Draft
CurveCWSFourier Class for CWS bounded coil optimization#420joaopedrobiu6 wants to merge 131 commits intohiddenSymmetries:masterfrom
joaopedrobiu6 wants to merge 131 commits intohiddenSymmetries:masterfrom
Conversation
Contributor
|
@lankef Frank, tagging you here in case you haven't seen this pull request and its helpful for you |
|
Thank you, I didn't notice. I'll check if it solves the gradient issue. There doesn't seem to be any change to the flux objective's implementation though?
Frank
…________________________________
From: Alan Kaptanoglu ***@***.***>
Sent: Friday, June 14, 2024 14:44
To: hiddenSymmetries/simsopt ***@***.***>
Cc: Frank Fu ***@***.***>; Mention ***@***.***>
Subject: Re: [hiddenSymmetries/simsopt] CurveCWSFourier Class for CWS bounded coil optimization (PR #420)
@lankef<https://github.com/lankef> Frank, tagging you here in case you haven't seen this pull request and its helpful for you
—
Reply to this email directly, view it on GitHub<#420 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADDUGMR73V2UC4SUKJVX7ULZHM2X3AVCNFSM6AAAAABI3EVBYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRYGU3TEOJXHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Merge main simsopt with curvecwsfourier working branch
This reverts commit fb04e68.
Contributor
|
@joaopedrobiu6 is this PR still in progress or should we close? |
Author
|
@mishapadidar, me and @rogeriojorge I are solving some merge conflicts between our branch and the master and we'll probably open a PR instead of just a draft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables SIMSOPT to create coil curves on a specified coil winding surface. For this purpose, the following changes are implemented.
Need to add unit tests.
(João Biu, student of Rogério Jorge)