Conversation
…n a current potential object.
…e actually compiled when we try this.
… the winding surface.
…r the winding surface field objects.
…ck compilation on cori.
…dded a test benchmark using the calculation in Eqs 31 and 32 in the efficient fields paper by matt landreman and allen boozer but havent finished yet.
…ible with CurrentPotentialFourier.
…high aspect ratio, circular cross section torus test file. However, seems to be an error with the get_dofs function in the SurfaceRZFourier call now. Not sure if this is my issue with calling the function or Elizabeth broke something in the code.
…nst the analytic solution, and correctly reduces to a dipole in the far field limit. Testing the expanded fields very close to the finite-width current loop (high aspect ratio circular tokamak) is still not quite working but should be able to finish this up next week pretty easily.
…al. Test now passing.
…e is not polished or clear what its trying to accomplish/show, and the figures are not coming up properly. unit tests are not fully working, and test_regcoil_write takes ages, not sure why its so slow.
…dramatically, it was computing the lipschitz constant very slowly. Updated the example and got the unit tests running much better.
…d is not available. Remove quadcoil functionality that frank briefly implemented. Update and fix tests. Remove unnecessary diffs with main branch.
…t touched this functionality on this branch. Adding an except in case that helps.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #596 +/- ##
==========================================
+ Coverage 89.97% 90.56% +0.58%
==========================================
Files 84 86 +2
Lines 17364 18785 +1421
==========================================
+ Hits 15623 17012 +1389
- Misses 1741 1773 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…hich at least correctly is giving helical coils actually on the original winding surface.
…tential and regcoil stuff.
…o: validate that the coil cutting is actually working well.
…or when running non stellarator symmetric example.
…, reduce util functions.
…gs in the helper functions.
lankef
previously approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REGCOIL functionality has been languishing on a separate branch for a while, but I believe is fully functional and just needs some polishing, clean-up, unit tests. Trying to get this up to speed.