-
Notifications
You must be signed in to change notification settings - Fork 123
feat: replacing txid when mempool transaction is dropped by fee and r… #2141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…eplaced with another
There is a requirement in the stacks core repo to be merged for this pull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the very extensive delay @usagi32 , left a few comments. After that it LGTM
exports.up = pgm => { | ||
pgm.addColumn('mempool_txs', { | ||
replacing_txid: { | ||
type: 'string', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be bytea
@@ -1235,6 +1238,7 @@ export interface MempoolTxInsertValues { | |||
type_id: DbTxTypeId; | |||
anchor_mode: DbTxAnchorMode; | |||
status: DbTxStatus; | |||
replacing_txid: string | null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PgBytea | null
solves #1813
This will provide extra information for a transaction which is replaced by another. This can be used for replace-by-fee or maybe replace-across-fork but not sure though if replace-across-fork gives a new_txid or uses the previous one.
Nevertheless, @zone117x