Skip to content

feat: replacing txid when mempool transaction is dropped by fee and r… #2141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

usagi32
Copy link

@usagi32 usagi32 commented Oct 24, 2024

solves #1813

This will provide extra information for a transaction which is replaced by another. This can be used for replace-by-fee or maybe replace-across-fork but not sure though if replace-across-fork gives a new_txid or uses the previous one.

Nevertheless, @zone117x

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2024

CLA assistant check
All committers have signed the CLA.

@usagi32
Copy link
Author

usagi32 commented Oct 24, 2024

There is a requirement in the stacks core repo to be merged for this pull

Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the very extensive delay @usagi32 , left a few comments. After that it LGTM

exports.up = pgm => {
pgm.addColumn('mempool_txs', {
replacing_txid: {
type: 'string',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be bytea

@@ -1235,6 +1238,7 @@ export interface MempoolTxInsertValues {
type_id: DbTxTypeId;
anchor_mode: DbTxAnchorMode;
status: DbTxStatus;
replacing_txid: string | null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PgBytea | null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

4 participants