Refactor Quoters/Delimiters and add validation logic #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored `Quoters` and `Delimiters` properties to use private backing fields and added validation to prevent overlapping characters between them. Introduced a constant error message `CommonCharactersErrorMessage` for validation failures. Changed `CsvDelimiters` to use `ImmutableHashSet` for immutability. Added a new test case `TestMethodSingleCommon` to ensure validation logic works as expected. Updated imports to include `System.Collections.Immutable`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Quoters/Delimiters and add validation logic
Refactored
QuotersandDelimitersproperties to use privatebacking fields and added validation to prevent overlapping
characters between them. Introduced a constant error message
CommonCharactersErrorMessagefor validation failures.Changed
CsvDelimitersto useImmutableHashSetfor immutability.Added a new test case
TestMethodSingleCommonto ensure validationlogic works as expected. Updated imports to include
System.Collections.Immutable.