Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solar charging options to Wallbox integration #139286

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

jorisdrenth
Copy link

@jorisdrenth jorisdrenth commented Feb 25, 2025

Proposed change

Wallbox has an option in their app to charge a car using energy from a users solar panels. In the Wallbox app this can be turned off, or either one of two modes can be selected: eco mode, which starts charging at 2A and fills with energy from the net till 6A, or full solar, which starts charging at 6A energy from solar panels. A Wallbox Load balancer is needed for this functionality.

This PR adds an "Solar charging" entity to the Wallbox integration. It features a select with three options: "Off", "Eco mode" or "Full solar". This way the solar charging mode can be controlled via Home Assistant. Entity availability is checked with the Power Boost availability (Wallbox' confusing name for the load balancer).

For the API communication I also opened a PR to the Wallbox python project: cliviu74/wallbox#63. The merging of that PR is blocking for this PR.

Disclaimer: it's been 5 year since I worked with Python and this is my first PR for Home Assistant. Looking forward to receive feedback in a constructive way.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jorisdrenth

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Hey there @hesselonline, mind taking a look at this pull request as it has been labeled with an integration (wallbox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of wallbox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign wallbox Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@jorisdrenth
Copy link
Author

PR cliviu74/wallbox#63 has been merged so I'll open this PR for review.

@jorisdrenth jorisdrenth marked this pull request as ready for review February 28, 2025 18:49
@home-assistant home-assistant bot marked this pull request as draft February 28, 2025 23:20
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@jorisdrenth jorisdrenth mentioned this pull request Feb 28, 2025
19 tasks
@jorisdrenth jorisdrenth marked this pull request as ready for review February 28, 2025 23:59
@home-assistant home-assistant bot requested a review from abmantis February 28, 2025 23:59
@hesselonline
Copy link
Contributor

@jorisdrenth code looks fine, but please add sufficient tests for the new component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants