Unify number slider threshold across rows and state cards#53224
Draft
piitaya wants to merge 1 commit into
Draft
Conversation
maartenla
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Three places decide whether a
numberentity inautomode renders a slider or a text box, and one of them gets it wrong.state-card-numbercomparesmax - minagainst 256, the other two compare(max - min) / step.So a number with min 0, max 1000, step 10 renders a slider in the Lovelace row and the config flow preview, and a text box in the state card, for 100 steps in every case.
Extracted
showNumberSliderintosrc/data/number.tsand used it at all three sites, rather than spelling the formula a third time.This changes what the state card renders for entities whose range is above 256 but whose step count is not, so it is a visible change worth a look. The row and the preview are unaffected, their behaviour is what the state card now matches.
Screenshots
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed:
To help with the load of incoming pull requests: