-
Notifications
You must be signed in to change notification settings - Fork 58
ci: switch to release please and deprecate github pat #649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added permission for repository-projects to support release-please-action.
|
@rabidpraxis Can I please get your input on this PR? CI is failing and I'm thinking it's unrelated to my changes. This test is failing consistently with Elixir 1.17 and 1.18:
|
otp 28.0 lacks public_key required by x509 for test dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modernizes the release automation workflow by migrating from the expublish tool to Google's release-please-action, and improves test reliability with better timing controls.
- Replaces manual
expublish-based releases with automatedrelease-pleaseworkflow - Fixes test timing issues by reducing sleep duration and adding synchronous calls
- Updates dependencies and tooling to current versions
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/honeybadger/events_sampler_test.exs | Optimizes test timing by reducing sleep from 1000ms to 110ms and adds synchronous call to ensure message processing |
| mix.exs | Removes expublish dependency no longer needed with new release workflow |
| mix.lock | Removes expublish and updates x509 to version 0.9.2 |
| .github/workflows/publish.yml | Replaces manual workflow dispatch with automated release-please action for release management |
| .github/workflows/elixir.yml | Updates OTP version from 28.0 to 28.1 for the latest Elixir 1.18 test matrix |
| .github/workflows/check-pr-title.yml | Adds new workflow to validate PR titles follow conventional commit format |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This is ready, though I haven't tested it. Are we OK with merging and testing when we decide to do a release? |
Yup! |
release-please-action, which enables:CHANGELOG.mdgenerationNotes:
GITHUB_TOKEN.