Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adapter/aws-lambda): APIGWProxyResult should contain either of headers or multiValueHeaders, not both #3883

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Feb 1, 2025

Closes #3870

  • APIGWProxyResult now contains headers or multiValueHeaders mutually-exclusively.
  • handle is tweaked so the response type can be inferred from the request event type.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@exoego exoego changed the title fix(adapter/aws-lambda): API GW Proxy Result should contain either of headers or multiValueHeaders, not both fix(adapter/aws-lambda): APIGWProxyResult should contain either of headers or multiValueHeaders, not both Feb 1, 2025
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.28%. Comparing base (035c2d7) to head (ce60722).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3883      +/-   ##
==========================================
- Coverage   91.32%   91.28%   -0.04%     
==========================================
  Files         168      168              
  Lines       10687    10767      +80     
  Branches     3021     3091      +70     
==========================================
+ Hits         9760     9829      +69     
- Misses        926      937      +11     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rown89
Copy link

rown89 commented Mar 18, 2025

Hello, i have the same duplicate header issue, someone can take care of this PR and maybe merge ? :)

@exoego exoego marked this pull request as ready for review March 18, 2025 13:08
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@exoego

Looks good to me! I'll merge now. Thank you!

@yusukebe yusukebe merged commit 0e4dfe5 into honojs:main Mar 19, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-lambda duplicate headers in API Gateway V1 response
3 participants