Skip to content

Upgrade deprecated actions/cache in workflow to v4 + fix failing unit test #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StijnKlopper2k merged 2 commits into from
Feb 11, 2025
Merged

Upgrade deprecated actions/cache in workflow to v4 + fix failing unit test #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1166e66
Upgrade deprecated actions/cache in workflow to v4
Feb 11, 2025
22f946c
Fix order of persisted entities in failing unit test
Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,9 @@ jobs:
php-version: ${{ matrix.php-versions }}
- name: Get composer cache directory
id: composer-cache
run: echo "::set-output name=dir::$(composer config cache-files-dir)"
- uses: actions/cache@v2
run: |
echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
- uses: actions/cache@v4
with:
path: ${{ steps.composer-cache.outputs.dir }}
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
Expand Down
2 changes: 1 addition & 1 deletion test/Provider/EntityMutationMetadataProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public function testChangesNewEntityFlushed(): void

self::assertEquals([
Gallery::class => [$gallery],
Visitor::class => [$v1, $v2],
Visitor::class => [$v2, $v1],
], $this->provider->getFullChangeSet($this->em));
}

Expand Down