Skip to content

Commit 17577a4

Browse files
matthewtreptehougantc-nvda
authored andcommitted
Fixes for missing desktop icon when running scripts on DGX Spark (isaac-sim#3804)
# Description <!-- Thank you for your interest in sending a pull request. Please make sure to check the contribution guidelines. Link: https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html 💡 Please try to keep PRs small and focused. Large PRs are harder to review and merge. --> Fix for missing desktop icon when running scripts on DGX Spark <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Screenshots Please attach before and after screenshots of the change if applicable. <!-- Example: | Before | After | | ------ | ----- | | _gif/png before_ | _gif/png after_ | To upload images to a PR -- simply drag and drop an image while in edit mode and it should upload the image directly. You can then paste that source into the above before/after sections. --> ## Checklist - [ ] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
1 parent 102606c commit 17577a4

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

isaaclab.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -563,6 +563,10 @@ while [[ $# -gt 0 ]]; do
563563
break
564564
;;
565565
-p|--python)
566+
# ensures Kit loads Isaac Sim’s icon instead of a generic icon on aarch64
567+
if is_arm; then
568+
export RESOURCE_NAME="${RESOURCE_NAME:-IsaacSim}"
569+
fi
566570
# run the python provided by isaacsim
567571
python_exe=$(extract_python_exe)
568572
echo "[INFO] Using python from: ${python_exe}"

0 commit comments

Comments
 (0)