Draft
Conversation
…o be used for debugging recovery.
Unfortunately, recreating the device fails on NV.
|
This is similar to dolphin emulator dolphin-emu/dolphin#12191 |
|
@FATCatAndroid12 Not really. My PR was meant to help debug the cause of device lost errors so they can be fixed later rather than handle them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to gracefully teardown and recreate the Vulkan device if this happens due to either emulator or driver bug.
Currently, we don't fully implement LostDevice/RestoreDevice for Vulkan (as called from Android task switching), as in reality we do keep around the same device. So we don't delete/recreate everything, just most things, and finding the last things might be tricky.
However I was able to get this working to some degree on Intel GPU on Windows. On NVIDIA, I can't seem to create a new device in the same process after I've crashed one.
So overall, this is a bit questionable. Might be better to try to root out the remaining causes of lost device, although it would be nice to have this as a safety net.