Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces version 3.0 with a new cross-platform API while removing legacy platform-specific and dependency configurations. Key changes include updates to the Swift Package Manager configuration (dropping explicit platform settings and CocoaPods support), a streamlined CI workflow using swift test on multiple OSes, and the removal of outdated playground and tooling files.
Reviewed Changes
Copilot reviewed 34 out of 37 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Package.swift | Updated package configuration to expose the new cross-platform API and remove legacy platform restrictions. |
| LICENSE | Updated copyright notice to reflect new contribution dates. |
| HSLuviOS.playground/* | Removed outdated playground files and timeline configuration. |
| HSLuvSwift.xcworkspace / xcschemes | Removed obsolete Xcode workspace settings and shared schemes. |
| HSLuvSwift.podspec | Dropped CocoaPods support in favor of SPM exclusively. |
| CHANGELOG.md | Added changelog documenting breaking changes and new API features. |
| .github/workflows/ci.yml | Updated CI workflow to run swift tests across multiple OSes using a new matrix strategy. |
| .devcontainer/* | Added support for a dev container via Docker and VSCode customizations. |
Files not reviewed (3)
- .swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata: Language not supported
- HSLuvSwift.xcodeproj/project.xcworkspace/contents.xcworkspacedata: Language not supported
- HSLuvSwift.xcworkspace/contents.xcworkspacedata: Language not supported
Comments suppressed due to low confidence (2)
Package.swift:7
- The removal of explicit platform targets and previous product configurations may confuse users. Consider updating the package documentation or comments to clearly explain the new cross-platform design and its implications.
.library(name: "HSLuv", targets: ["HSLuv"])
.github/workflows/ci.yml:25
- Replacing the xcodebuild command with 'swift test' may bypass platform-specific tests previously run with an iOS simulator. Ensure that the new test command covers all necessary test cases across the supported platforms.
run: swift test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browse files for v3: https://github.com/hsluv/hsluv-swift/tree/wip-v3