Fix Windows guard in man page availability check#1900
Open
yoshibase wants to merge 1 commit into
Open
Conversation
yoshibase
force-pushed
the
fix/issue-1898-windows-man-pages-guard
branch
3 times, most recently
from
July 25, 2026 04:11
56d28ff to
6f982a9
Compare
Use sys.platform instead of comparing the os.system function to a string, and cover the guard and subprocess outcomes. Fixes httpie#1898
yoshibase
force-pushed
the
fix/issue-1898-windows-man-pages-guard
branch
from
July 25, 2026 04:16
6f982a9 to
f84b3ce
Compare
Author
|
CI note after the clean rebuild: The coverage failure is the same pre-existing Big5 detection failure in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1898.
is_available()compared theos.systemfunction object to"nt", so the intended Windows short-circuit could never run. Usesys.platform == "win32"and cover every return path.Test plan
pytest tests/test_man_pages.py— 5 passedflake8 httpie/output/ui/man_pages.py tests/test_man_pages.pyHTTPIE_NO_MAN_PAGES, successful/failedman, and execution-error paths covered