Improve QR code flow & permissions, and update lots of assorted build config & Android API usage

[cHAuHaNz]

• Improved the UI of ApplicationsList screen
• Apps can also be launched by clicking on app from the list
• Converted isProbablyEmulator to a function, since the value is only used once (when the app is started), we do not need to retain it in the memory by using a variable
• Fixed - If camera permission is denied, clicking Scan QR button shows couldn't connect (Videos Attached)
• Migrated to ActivityResultContracts instead of using deprecated startActivityForResult()
• Migrated lib dependencies to Version Catalogs
• Migrated build configuration from Groovy to Kotlin

Existing UI	New UI

HttpToolkitCameraBug.webm

HttpToolkitCameraBugFixed.webm

Tested on Android 9, Android 11 & Android 15

[pimterry]

Hi @cHAuHaNz. Thanks for contributing! I'm afraid I'm away right now, so I'm not going to review this immediately, but I'll take a closer look next week.

[pimterry]

Hi @cHAuHaNz, can you explain more about what you mean by "Improved the UI of ApplicationsList screen"? It looks like the main change is moving the dropdown menu into a modal popup, but I'm not sure what benefit that provides.

[cHAuHaNz]

Hi @pimterry, I've updated the PR to have Before/After screenshots of the UI in question. You can have a took there. Also, I have made some more improvements in the project. Do check the bullet points once again.

[pimterry]

Ok, thanks for increasing the detail there. I appreciate the work you've done here, but I'm afraid I'm not sure I want to include some of these changes. I'll go through the list:

• Improved the UI of ApplicationsList screen
  • It's subjective, but personally I think the menu, UI without lines, and toggle instead of checkboxes is clearer, so I don't want to include this
• Apps can also be launched by clicking on app from the list
  • I think this is more likely to be confusing than helpful - I don't think people open this menu intending to open the app they select.
• Converted isProbablyEmulator to a function, since the value is only used once (when the app is started), we do not need to retain it in the memory by using a variable
  • Saving a single boolean from memory isn't really a meaningful improvement, no Android device is that tight on memory, and while we don't currently use this later we might want to, so it's mildly better to avoid recalculating it in that case. It's not a big deal, but I don't think this is worth changing.
• Fixed - If camera permission is denied, clicking Scan QR button shows couldn't connect (Videos Attached)
  • This is very useful! Thank you, good idea.
• Migrated to ActivityResultContracts instead of using deprecated startActivityForResult()
  • Also very useful, thanks I've been meaning to explore that.
• Migrated lib dependencies to Version Catalogs
  • That's a nice update, thank you
• Migrated build configuration from Groovy to Kotlin
  • That's a nice update, thank you

Sorry, I suspect that's not what you want to hear, in future do feel free to open issues with suggestions before working on them and I'm happy to discuss in advance.

The improvements I've ticked in the list above though would genuinely be very nice to have. Could you simplify the code you've included here to just those changes, and rebase to drop the commits for the other changes? Once that's done, I'm happy to do a proper review of those changes in depth.

[cHAuHaNz]

@pimterry Its done, feel free to let me know if you need anything else.

[pimterry]

Thanks @cHAuHaNz! Lots of nice improvements here, great work. I'll release this as v1.5.1 shortly 😄

[cHAuHaNz]

Sure thing @pimterry! You're Welcome 😇
I hope I can contribute more to this project in future. HTTPToolkit is once of great tools I've used for traffic inspection ever.
I didn't know its open source at first, then I came across this 😅 and thought I can surely contribute to this project.

[pimterry]

More contributions very welcome! Let me know if you want to discuss potential ideas. All contributors do get free Pro - if that is something you're interested in, just let me know your email (here or by emailing me at tim @ httptoolkit.com) and I'll set you up.

[cHAuHaNz]

Well never say no to anything free, so I'll drop an email on the address you mentioned above. Thanks for being generous.