Adopt cross-repo dependency versioning and shared CI - #124
Conversation
Git-version, public Maven repo DSL, kotlin-abi-validation, and root conventions. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reached
Next review available in: 4 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (18)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the build configuration by modularizing build logic into several new convention plugins (such as common-conventions, dokka-convention, version, and maven-central) and updating Kotlin and other dependency versions. It also configures the public-open-source-dependency-repositories plugin in settings.gradle.kts. A review comment points out that the gradleCommonPluginsVersion variable is defined in VersionsAndDependencies.kt but is unused, as it is already defined locally in buildSrc/build.gradle.kts where it is needed.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
OSS Exposed Vert.x SQL client: reusable CI/publish workflows with secrets: inherit; align gradleCommonPluginsVersion to gradle-common dev-commit on this branch. Part of improve-cross-repo-dependency overhaul; user reviewed workflow and version pin changes after initial agent draft. Co-authored-by: Cursor <cursoragent@cursor.com>
Point gradle-common and internal dependency coordinates at clean -dev-commit-<hash> versions from improve-cross-repo-dependency commits (not -dirty-SNAPSHOT). Update gradleCommonPluginsVersion to gradle-common 7fe538f. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Follow gradle-common 99eef7d for git-based versioning and renamed team plugins. - Inline projectVersionFromGitProvider into conventions.gradle.kts (main branch location) and remove the PR-added version.gradle.kts script - Enable abiValidation() on lib-conventions, matching main branch root build.gradle.kts scope - Rename publish and root-project plugin IDs - Add exclusiveContent-filtered pluginManagement GPR for gradle-common - Drop this repo and gradle-common from githubPackages in dependency settings; gradle-common is build logic, not a runtime dependency repository
83bf499 to
b934c2e
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
Use thin settings modules from gradle-common#71, extract the shared plugins version in settings, and switch buildSrc to project-gradle-plugins. Co-authored-by: Cursor <cursoragent@cursor.com>
Adopt mavenCentralExcludingHuanshankeji, version-partitioned githubPackages, and consistent repository call order. Co-authored-by: Cursor <cursoragent@cursor.com>
Internal releases resolve from GitLab only; SNAPSHOTs stay on mavenLocal. Co-authored-by: Cursor <cursoragent@cursor.com>
…NAPSHOT suffixes on -dev-commit- versions.
…dlerContext. Co-authored-by: Cursor <cursoragent@cursor.com>
…ettings DRM. Co-authored-by: Cursor <cursoragent@cursor.com>
Extract version and GitHub Packages exclusiveContent into classpath-bootstrap.gradle.kts so pluginManagement and buildSrc no longer duplicate the chicken/egg wiring, and buildSrc can resolve *-dev-commit-* plugins without mavenLocal.
Local builds that resolve gradle-common plugins or sibling dependency libraries from GitHub Packages need gpr.user/gpr.key with read:packages. Co-authored-by: Cursor <cursoragent@cursor.com>
CI is covered by the shared gradle-ci reusable workflow via ci.yml. Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve gradle-common plugins from GPR and align JDK/Gradle setup with shared CI. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…to ProviderFactory API.
Pin gradle-common to aa62d59 so the settings helpers are on the team settings classpath.
f2add58 to
ac593fd
Compare
…on to eae34a0. Use the team GitHub Packages/Maven Central publish plugin with gitVersioningOpenSourceConventionGithubPackagesPublish.signAllPublicationsIfRelease, switch versions to devCommitOrReleaseVersionProvider, and pin gradle-common to 0.12.0-dev-commit-eae34a0cc36c830cb52880c4df06747ad2abca79.
ac593fd to
7097b8f
Compare
Inline and remove common-conventions / dokka-convention added in 72322c6, keeping publish and ABI behavior in lib-conventions. Co-authored-by: Cursor <cursoragent@cursor.com>
|
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
1 participant
Summary
Adopt the dev-commit cross-repo dependency model and shared CI for exposed-vertx-sql-client.
mavenCentralExcludingHuanshankeji+ version-partitioned GitHub Packages); applybase-settings-conventions; drop project-level repo declarationsdevCommitOrReleaseVersionProviderwithisRelease; opensourceconvention GitHub Packages publish (signAllPublicationsIfRelease); Kotlin ABI validation and shared Dokka convention; extractcommon-conventions.gradle.kts; share the gradle-common classpath bootstrap betweensettings.gradle.ktsandbuildSrcci.yml/publish.ymlreusable workflows, updatecodecov.yml(GPR credentials + shared setup), remove legacykotlin-jvm-ci, and bump related ActionsCONTRIBUTING.mdTest plan
./gradlew check --no-daemon(excluding Docker integration tests)Made with Cursor