Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ELB): add params to elb ip group resource #6544

Merged
merged 1 commit into from
Mar 25, 2025
Merged

feat(ELB): add params to elb ip group resource #6544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 9 additions & 22 deletions docs/resources/elb_ipgroup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
subcategory: "Dedicated Load Balance (Dedicated ELB)"
layout: "huaweicloud"
page_title: "HuaweiCloud: huaweicloud_elb_ipgroup"
description: ""
description: |-
Manages a Dedicated ELB Ip Group resource within HuaweiCloud.
---

# huaweicloud_elb_ipgroup
Expand Down Expand Up @@ -35,11 +36,12 @@ The following arguments are supported:
* `description` - (Optional, String) Human-readable description for the ip group.

* `ip_list` - (Required, List) Specifies an array of one or more ip addresses. The ip_list object structure is
documented below.
documented below. The [ip_list](#ELB_iplistResp) structure is documented below.

* `enterprise_project_id` - (Optional, String, ForceNew) The enterprise project id of the ip group. Changing this
creates a new ip group.

<a name="ELB_iplistResp"></a>
The `ip_list` block supports:

* `ip` - (Required, String) IP address or CIDR block.
Expand All @@ -54,29 +56,14 @@ In addition to all arguments above, the following attributes are exported:

* `listener_ids` - The listener IDs which the ip group associated with.

* `created_at` - The create time of the ip group.
* `created_at` - The creation time of the ip group.

* `updated_at` - The update time of the ip group.

ELB IP group can be imported using the IP group ID, e.g.
## Import

```bash
$ terraform import huaweicloud_elb_ipgroup.group_1 5c20fdad-7288-11eb-b817-0255ac10158b
```
The ELB IP group can be imported using the `id`, e.g.

Note that the imported state may not be identical to your resource definition, due to some attributes missing from the
API response, security or some other reason. The missing attributes include: `enterprise_project_id`.
It is generally recommended running `terraform plan` after importing a IP group.
You can then decide if changes should be applied to the IP group, or the resource
definition should be updated to align with the IP group. Also you can ignore changes as below.

```hcl
resource "huaweicloud_elb_ipgroup" "group_1" {
...
lifecycle {
ignore_changes = [
enterprise_project_id,
]
}
}
```bash
$ terraform import huaweicloud_elb_ipgroup.test <id>
```
166 changes: 57 additions & 109 deletions huaweicloud/services/acceptance/elb/resource_huaweicloud_elb_ipgroup_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,41 +2,79 @@ package elb

import (
"fmt"
"strings"
"testing"

"github.com/hashicorp/terraform-plugin-sdk/v2/helper/acctest"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"

"github.com/chnsz/golangsdk/openstack/elb/v3/ipgroups"
"github.com/chnsz/golangsdk"

"github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/config"
"github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance"
"github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/utils"
)

func getELBIpGroupResourceFunc(cfg *config.Config, state *terraform.ResourceState) (interface{}, error) {
var (
httpUrl = "v3/{project_id}/elb/ipgroups/{ipgroup_id}"
product = "elb"
)
client, err := cfg.NewServiceClient(product, acceptance.HW_REGION_NAME)
if err != nil {
return nil, err
}

getPath := client.Endpoint + httpUrl
getPath = strings.ReplaceAll(getPath, "{project_id}", client.ProjectID)
getPath = strings.ReplaceAll(getPath, "{ipgroup_id}", state.Primary.ID)

getOpt := golangsdk.RequestOpts{
KeepResponseBody: true,
}

getResp, err := client.Request("GET", getPath, &getOpt)
if err != nil {
return nil, err
}

return utils.FlattenResponse(getResp)
}

func TestAccElbV3IpGroup_basic(t *testing.T) {
var c ipgroups.IpGroup
name := fmt.Sprintf("tf-acc-%s", acctest.RandString(5))
var obj interface{}
rName := acceptance.RandomAccResourceNameWithDash()
updateName := acceptance.RandomAccResourceNameWithDash()
resourceName := "huaweicloud_elb_ipgroup.test"

rc := acceptance.InitResourceCheck(
resourceName,
&obj,
getELBIpGroupResourceFunc,
)

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acceptance.TestAccPreCheck(t) },
ProviderFactories: acceptance.TestAccProviderFactories,
CheckDestroy: testAccCheckElbV3IpGroupDestroy,
CheckDestroy: rc.CheckResourceDestroy(),
Steps: []resource.TestStep{
{
Config: testAccElbV3IpGroupConfig_basic(name),
Config: testAccElbV3IpGroupConfig_basic(rName),
Check: resource.ComposeTestCheckFunc(
testAccCheckElbV3IpGroupExists(resourceName, &c),
resource.TestCheckResourceAttr(resourceName, "name", name),
rc.CheckResourceExists(),
resource.TestCheckResourceAttr(resourceName, "name", rName),
resource.TestCheckResourceAttr(resourceName, "description", "terraform test"),
resource.TestCheckResourceAttr(resourceName, "enterprise_project_id", "0"),
resource.TestCheckResourceAttr(resourceName, "ip_list.#", "1"),
resource.TestCheckResourceAttr(resourceName, "ip_list.0.ip", "192.168.10.10"),
resource.TestCheckResourceAttr(resourceName, "ip_list.0.description", "ECS01"),
),
},
{
Config: testAccElbV3IpGroupConfig_update(name),
Config: testAccElbV3IpGroupConfig_update(updateName),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr(resourceName, "name", fmt.Sprintf("%s_updated", name)),
rc.CheckResourceExists(),
resource.TestCheckResourceAttr(resourceName, "name", updateName),
resource.TestCheckResourceAttr(resourceName, "description", "terraform test updated"),
resource.TestCheckResourceAttr(resourceName, "ip_list.#", "2"),
),
Expand All @@ -50,90 +88,15 @@ func TestAccElbV3IpGroup_basic(t *testing.T) {
})
}

func TestAccElbV3IpGroup_withEpsId(t *testing.T) {
var c ipgroups.IpGroup
name := fmt.Sprintf("tf-acc-%s", acctest.RandString(5))
resourceName := "huaweicloud_elb_ipgroup.test"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acceptance.TestAccPreCheckEpsID(t) },
ProviderFactories: acceptance.TestAccProviderFactories,
CheckDestroy: testAccCheckElbV3IpGroupDestroy,
Steps: []resource.TestStep{
{
Config: testAccElbV3IpGroupConfig_withEpsId(name),
Check: resource.ComposeTestCheckFunc(
testAccCheckElbV3IpGroupExists(resourceName, &c),
resource.TestCheckResourceAttr(resourceName, "name", name),
resource.TestCheckResourceAttr(resourceName, "enterprise_project_id", acceptance.HW_ENTERPRISE_PROJECT_ID_TEST),
),
},
},
})
}

func testAccCheckElbV3IpGroupDestroy(s *terraform.State) error {
cfg := acceptance.TestAccProvider.Meta().(*config.Config)
elbClient, err := cfg.ElbV3Client(acceptance.HW_REGION_NAME)
if err != nil {
return fmt.Errorf("error creating ELB client: %s", err)
}

for _, rs := range s.RootModule().Resources {
if rs.Type != "huaweicloud_elb_ipgroup" {
continue
}

_, err := ipgroups.Get(elbClient, rs.Primary.ID).Extract()
if err == nil {
return fmt.Errorf("ipGroup still exists: %s", rs.Primary.ID)
}
}

return nil
}

func testAccCheckElbV3IpGroupExists(
n string, c *ipgroups.IpGroup) resource.TestCheckFunc {
return func(s *terraform.State) error {
rs, ok := s.RootModule().Resources[n]
if !ok {
return fmt.Errorf("not found: %s", n)
}

if rs.Primary.ID == "" {
return fmt.Errorf("no ID is set")
}

cfg := acceptance.TestAccProvider.Meta().(*config.Config)
elbClient, err := cfg.ElbV3Client(acceptance.HW_REGION_NAME)
if err != nil {
return fmt.Errorf("error creating ELB client: %s", err)
}

found, err := ipgroups.Get(elbClient, rs.Primary.ID).Extract()
if err != nil {
return err
}

if found.ID != rs.Primary.ID {
return fmt.Errorf("ipGroup not found")
}

*c = *found

return nil
}
}

func testAccElbV3IpGroupConfig_basic(name string) string {
return fmt.Sprintf(`
resource "huaweicloud_elb_ipgroup" "test"{
name = "%s"
description = "terraform test"
name = "%s"
description = "terraform test"
enterprise_project_id = "0"

ip_list {
ip = "192.168.10.10"
ip = "192.168.10.10"
description = "ECS01"
}
}
Expand All @@ -143,34 +106,19 @@ resource "huaweicloud_elb_ipgroup" "test"{
func testAccElbV3IpGroupConfig_update(name string) string {
return fmt.Sprintf(`
resource "huaweicloud_elb_ipgroup" "test"{
name = "%s_updated"
description = "terraform test updated"
name = "%s"
description = "terraform test updated"
enterprise_project_id = "0"

ip_list {
ip = "192.168.10.10"
ip = "192.168.10.10"
description = "ECS01"
}

ip_list {
ip = "192.168.10.11"
ip = "192.168.10.11"
description = "ECS02"
}
}
`, name)
}

func testAccElbV3IpGroupConfig_withEpsId(name string) string {
return fmt.Sprintf(`
resource "huaweicloud_elb_ipgroup" "test"{
name = "%s"
description = "terraform test"

ip_list {
ip = "192.168.10.10"
description = "ECS01"
}

enterprise_project_id = "%s"
}
`, name, acceptance.HW_ENTERPRISE_PROJECT_ID_TEST)
}
Loading
Loading