Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lts): add new resource supports kafka instance register to LTS #6565

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

wuzhuanhong
Copy link
Contributor

What this PR does / why we need it:
Add new resource supports kafka instance register to LTS.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

Add new resource supports kafka instance register to LTS. This is a one-time action resource.

PR Checklist

  • Tests added/passed.
 ./scripts/coverage.sh -o lts -f TestAccRegistKafkaInstance_
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/lts" -v -coverprofile="./huaweicloud/services/acceptance/lts/lts_coverage.cov" -coverpkg="./huaweicloud/services/lts" -run TestAccRegistKafkaInstance_ -timeout 360m -parallel 10
=== RUN   TestAccRegistKafkaInstance_basic
=== PAUSE TestAccRegistKafkaInstance_basic
=== RUN   TestAccRegistKafkaInstance_notSSL
=== PAUSE TestAccRegistKafkaInstance_notSSL
=== CONT  TestAccRegistKafkaInstance_basic
=== CONT  TestAccRegistKafkaInstance_notSSL
--- PASS: TestAccRegistKafkaInstance_notSSL (116.33s)
--- PASS: TestAccRegistKafkaInstance_basic (119.40s)
PASS
coverage: 11.0% of statements in ./huaweicloud/services/lts
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/lts       119.485s        coverage: 11.0% of statements in ./huaweicloud/services/lts
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

"github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/utils"
)

var nonUpdatableParams = []string{"instance_id", "kafka_name", "connect_info", "connect_info.*.user_name", "connect_info.*.pwd"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var nonUpdatableParams = []string{"instance_id", "kafka_name", "connect_info", "connect_info.*.user_name", "connect_info.*.pwd"}
var registerKafkaNonUpdatableParams = []string{"instance_id", "kafka_name", "connect_info", "connect_info.*.user_name", "connect_info.*.pwd"}

Avoid this vairable name conflict with others.

@Lance52259
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 26, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Lance52259

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 914a469 into huaweicloud:master Mar 26, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants