Conversation
Hosted QC needs a serializable mount spec on the task. Modal attaches each mount read-only; other runtimes reject the field. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Hosted QC (and any other Modal rollout that goes through
Task.runtime_config) cannot attach an S3 prefix as a POSIX path.ModalRuntimealready has constructor-only secrets, but those never reach the hosted worker.Solution
Add serializable
RuntimeConfig.mounts(RuntimeMount: path, bucket, prefix, secret). Modal attaches each as a read-only CloudBucketMount. Compose + mounts is rejected (DinD cannot pass mounts tomain). Docker, Daytona, and HUDRuntime reject the field.Outcome / Verification
test_modal_runtime_attaches_read_only_bucket_mountscovers pass-through, prefix/path validation, Compose rejection, and Docker rejection.test_docker_provider.pystill pass (20).Made with Cursor