refactor: new API & universal load functions #1743
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsarrazin
added
enhancement
* feat(auth): migrate login and logout to API routes - Replaced form-based login/logout with fetch-based API routes - Updated hooks and components to use new `/api/login` and `/api/logout` endpoints * fix: invalidate on logout * refactor: move `/api/login` routes back to `/login` and `/api/logout` to `/logout` remove breaing change to connected apps
- Changed `addChildren` and `addSibling` functions to utilize a generic `Tree` type for better flexibility. - Updated `buildSubtree` to return a tree node structure. - Modified conversation response types to use `Serialize<Conversation>` for improved serialization. - Adjusted related tests to align with the new tree structure and types.
- Updated the `messages` prop in the ChatWindow component to explicitly cast `messagesPath` as `Message[]` for improved type safety and clarity.
|
idk if I want to merge this. main issue is the API framework, elysia works ok but docs are poor and there's issues with the type safe client eden and it hasn't been updated in a few months. So in the end there's very little benefits over just adding API routes. I might just lift the logic into standard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This WIP PR addresses #1699 by expanding the API and moving all the server-side load functions to universal load functions that call the API endpoints instead.
This is important for shipping apps that must be bundled in SPA mode.
src/routes/+layout.server.tssrc/routes/assistant/[assistantId]/+page.server.tssrc/routes/assistants/+page.server.tssrc/routes/conversation/[id]/+page.server.tssrc/routes/login/callback/+page.server.ts(feat(api): migrate login and logout to API routes #1703)src/routes/models/[...model]/+page.server.tssrc/routes/settings/+layout.server.tssrc/routes/tools/+page.server.tssrc/routes/tools/[toolId]/+layout.server.ts