Skip to content

Add custom search engines in settings #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

maximizemaxwell
Copy link

What does this PR do?

Solution to Issue #1756
This PR lets chat-ui users pick the web-search provider (Serper/Google, Bing, DuckDuckGo, …) from Settings → Search Engine. The selected provider is stored in user settings, persisted to MongoDB, and passed through the RAG pipeline so that every web-search tool-call queries the engine the user chose.

Part of #1756

  • Send the list of available websearch providers from the back-end to the front-end in the load function.
  • An extra field in user settings to store the chosen provider with the UI for it in the settings page.
  • Modify the web search code to fetch the provider from user settings instead of the current function which just picks the first in a hardcoded order.

Who can review?

@nsarrazin could you review this PR?

@maximizemaxwell maximizemaxwell changed the title Add search engines in settings Add custom search engines in settings May 1, 2025
@gmanskibiditoilet
Copy link

keep going bro, you almost nailed it and made this feature a reality!

@gmanskibiditoilet
Copy link

@nsarrazin please check this PR to see if this feature works.

@nsarrazin
Copy link
Collaborator

Hi thanks for the contrib! Let me take a quick look

@nsarrazin nsarrazin self-requested a review May 6, 2025 08:03
@nsarrazin nsarrazin self-assigned this May 6, 2025
@gmanskibiditoilet
Copy link

almost there!

@gmanskibiditoilet
Copy link

Please note that this feature may not work due to the emergence of this issue #1812 , please fix this issue as well. it may affect the outcome of this PR because the search engine may not be able to detect information from the internet as issue #1812 has mentioned.

@gmanskibiditoilet
Copy link

@nsarrazin please review this PR once more. it is under pending.

@nsarrazin
Copy link
Collaborator

Hey @gmanskibiditoilet ! You've been posting under a lot of different issues lately, I just want to say I read everything and you really don't need to ping me on everything. I'm aware of what's on the board and I do my own prioritization. If you care about a feature, use the thumbs up reaction so I know it's important to you but you don't need to post every day, each time you do it I get an email notification 😅

@gmanskibiditoilet
Copy link

Hey @gmanskibiditoilet ! You've been posting under a lot of different issues lately, I just want to say I read everything and you really don't need to ping me on everything. I'm aware of what's on the board and I do my own prioritization. If you care about a feature, use the thumbs up reaction so I know it's important to you but you don't need to post every day, each time you do it I get an email notification 😅

alr, thanks for the notice

@gmanskibiditoilet

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants