Skip to content

fix: better args passthrough for _batch_setitems() #7817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: better args passthrough for _batch_setitems() #7817

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdc1784
update signature for _batch_setitems
sghng Oct 14, 2025
55e94d8
arguments passthrough
sghng Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/datasets/utils/_dill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,7 @@ def save(self, obj, save_persistent_id=True):
obj = getattr(obj, "_torchdynamo_orig_callable", obj)
dill.Pickler.save(self, obj, save_persistent_id=save_persistent_id)

def _batch_setitems(self, items):
if self._legacy_no_dict_keys_sorting:
return super()._batch_setitems(items)
def _batch_setitems(self, items, *args, **kwargs):
# Ignore the order of keys in a dict
try:
# Faster, but fails for unorderable elements
Expand All @@ -80,7 +78,7 @@ def _batch_setitems(self, items):
from datasets.fingerprint import Hasher

items = sorted(items, key=lambda x: Hasher.hash(x[0]))
dill.Pickler._batch_setitems(self, items)
return super()._batch_setitems(items, *args, **kwargs)

def memoize(self, obj):
# Don't memoize strings since two identical strings can have different Python ids
Expand Down
Loading