-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed requests.get function call by adding timeout parameter. #11156
Conversation
@DN6, I've made the requested changes. |
@bot /style |
Style fixes have been applied. View the workflow run here. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Failing test doesn't appear to have anything to do with these changes. |
@yiyixuxu is this PR just waiting on review or is the action with me at the moment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @kghamilton89
Failing tests are unrelated. |
What does this PR do?
Fixed requests.get() function call by adding configurable env variable timeout (default is 60 seconds).
Co-authored with @Sai-Suraj-27.
Fixes #7730
FYI: @DN6 and @asomoza
Before submitting
requests.get()
function call by addingtimeout
parameter #7742)documentation guidelines, and
here are tips on formatting docstrings.