Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed requests.get function call by adding timeout parameter. #11156

Merged
merged 8 commits into from
Apr 4, 2025

Conversation

kghamilton89
Copy link
Contributor

What does this PR do?

Fixed requests.get() function call by adding configurable env variable timeout (default is 60 seconds).

Co-authored with @Sai-Suraj-27.

Fixes #7730

FYI: @DN6 and @asomoza

Before submitting

@kghamilton89
Copy link
Contributor Author

@DN6, I've made the requested changes.

@hlky
Copy link
Member

hlky commented Mar 31, 2025

@bot /style

Copy link
Contributor

Style fixes have been applied. View the workflow run here.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@kghamilton89
Copy link
Contributor Author

Failing test doesn't appear to have anything to do with these changes.

@kghamilton89
Copy link
Contributor Author

@yiyixuxu is this PR just waiting on review or is the action with me at the moment?

Copy link
Member

@hlky hlky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @kghamilton89

@hlky
Copy link
Member

hlky commented Apr 4, 2025

Failing tests are unrelated.

@hlky hlky merged commit f10775b into huggingface:main Apr 4, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of requests call without timeout parameter
6 participants