Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Progress Bar Updates in SD 1.5 PAG Img2Img pipeline #9925

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

painebenjamin
Copy link
Contributor

What does this PR do?

StableDiffusionPAGImg2ImgPipeline does not properly update the progress bar during the denoising process, making progress silent when working in a terminal environment.

This PR brings this pipeline's progress bar functionality in line with other pipelines.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline?
  • Did you read our philosophy doc (important for complex PRs)?
  • Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case. Too minor for an issue, I think.
  • Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings. This brings the functionality in line with documentation, the other way around is not needed in this case.
  • Did you write any new necessary tests? Correct me if I'm wrong but I believe the progress bar functionality is not exercised in any existing tests.

Who can review?

Anyone can review, but based on the subject matter, @yiyixuxu and @asomoza seem to be the right folks.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@asomoza asomoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for the fix, the progress_bar.update was missing in the original PR

@asomoza
Copy link
Member

asomoza commented Nov 14, 2024

the failing test is unrelated (cogvideo)

@asomoza asomoza merged commit d74483c into huggingface:main Nov 14, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants